alamb commented on code in PR #7337:
URL: https://github.com/apache/arrow-rs/pull/7337#discussion_r2014867449


##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -698,32 +696,25 @@ impl<T: ChunkReader + 'static> Iterator for 
ReaderPageIterator<T> {
         let total_rows = rg.num_rows() as usize;
         let reader = self.reader.clone();
 
-        #[cfg(feature = "encryption")]

Review Comment:
   this code I found especially hard to work with, so I was able to move it 
into a method called `add_crypto_context` and then introduce a stub that 
doesn't do anything by default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to