WillAyd commented on code in PR #45854: URL: https://github.com/apache/arrow/pull/45854#discussion_r2022925677
########## python/pyarrow/meson.build: ########## @@ -0,0 +1,426 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +py = import('python').find_installation(pure: false) + +# When NumPy 2.0 becomes the minimum we can remove the +# custom location check +numpy_dep = dependency('numpy', required: false) Review Comment: Ah I see. The comment directly preceding this in the code touches on this but maybe needs clarification. When NumPy 2.0 becomes the minimum yes you can make that check required and it will work as you expect, as that support is built into Meson. However, since we still need to support NumPy < 2, this injects some custom code to fall back to calling `np.get_include()` whenever the system cannot detect NumPy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
