WillAyd commented on code in PR #45854: URL: https://github.com/apache/arrow/pull/45854#discussion_r2023206011
########## ci/appveyor-cpp-build.bat: ########## @@ -158,6 +192,6 @@ set PYARROW_TZDATA_PATH=%USERPROFILE%\Downloads\test\tzdata set AWS_EC2_METADATA_DISABLED=true set PYTHONDEVMODE=1 -python -m pytest -r sxX --durations=15 pyarrow/tests || exit /B - popd + +python -m pytest -r sxX --durations=15 --pyargs pyarrow || exit /B Review Comment: The pytest invocation had to change to get out of the python directory and add `--pyargs pyarrow` in this batch script. I guess this worked with setuptools before because it built inplace, but with Meson building out of place staying in that directory and invoking pytest will cause import errors. FWIW all of the other scripts are already using this pattern; my assumption is that it was an oversight to have this invocation like this on main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
