eli-schwartz commented on code in PR #45854: URL: https://github.com/apache/arrow/pull/45854#discussion_r2023038341
########## python/meson.build: ########## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +project( + 'pyarrow', + 'cython', + 'cpp', + version: run_command( + 'python', + '-m', + 'setuptools_scm', + '--force-write-version-files', + check: true, + ).stdout().strip(), + license: 'Apache-2.0', + meson_version: '>=1.4.0', + default_options: ['buildtype=release', 'warning_level=0', 'cpp_std=c++17'], Review Comment: You can of course add your own warning flags in meson, but meson provides a quick and easy way to set up some common values such as -Wall -Wextra -Wpedantic (and also clang's -Weverything, which is manually implemented in meson by encoding EVERY single warning option gcc knows about, and passing all of them. Because gcc devs did not want to add `-Weverything`, so meson users that wanted to do it in custom tests needed to manually implement it, and ended up adding it to meson's core.) Setting "0" here won't cause warnings to be suppressed. It simply means meson won't add its own -Wall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
