neilechao commented on code in PR #45375: URL: https://github.com/apache/arrow/pull/45375#discussion_r2027796649
########## cpp/src/parquet/arrow/variant.h: ########## @@ -0,0 +1,80 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <stdexcept> +#include <string> + +#include "arrow/extension_type.h" +#include "parquet/platform.h" + +namespace parquet::arrow { + +class PARQUET_EXPORT VariantArray : public ::arrow::ExtensionArray { + public: + using ::arrow::ExtensionArray::ExtensionArray; +}; + +/// EXPERIMENTAL: Variant is not yet fully supported. +/// +/// Variant supports semi-structured objects that can be composed of +/// primitives, arrays, and objects, which can be queried by path. +/// +/// An unshredded variant contains two binaries, one for the metadata and +/// one for the value. +/// +/// To read more about variant encoding, see the variant encoding spec at +/// https://github.com/apache/parquet-format/blob/master/VariantEncoding.md +class PARQUET_EXPORT VariantExtensionType : public ::arrow::ExtensionType { + public: + explicit VariantExtensionType(const std::shared_ptr<::arrow::DataType>& storage_type); Review Comment: I think [this](https://github.com/apache/arrow/pull/45375#discussion_r1969496594) is the thread where we discussed the placement of the VariantExtensionType. For testing purposes, variant is going to require a mammoth amount of utility functions - so much so that I think it merits its own variant_test_util.h/cc file. The functions that are part of VariantExtensionType don't quite extend into that category yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
