paleolimbot commented on code in PR #45375:
URL: https://github.com/apache/arrow/pull/45375#discussion_r2027792119
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -434,6 +454,11 @@ Status FieldToNode(const std::string& name, const
std::shared_ptr<Field>& field,
type = ParquetType::BYTE_ARRAY;
logical_type = LogicalType::JSON();
break;
+ } else if (ext_type->extension_name() == std::string("parquet.variant"))
{
+ auto variant_type =
std::static_pointer_cast<VariantExtensionType>(field->type());
Review Comment:
I agree that's the best final state. Perhaps renaming `variant.h/.cc` to
`variant_internal.h/cc` would accomplish the same thing here (i.e., don't
expose the type in installed headers quite yet). Also apologies if this has
already been hashed out in a previous review 😬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
