EnricoMi commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2028829108
##########
cpp/src/parquet/encryption/encryption.h:
##########
@@ -327,19 +322,19 @@ class PARQUET_EXPORT FileDecryptionProperties {
}
private:
- std::string footer_key_;
+ encryption::SecureString footer_key_;
std::string aad_prefix_;
std::shared_ptr<AADPrefixVerifier> aad_prefix_verifier_;
- const std::string empty_string_ = "";
+ const encryption::SecureString empty_string_ = encryption::SecureString("");
Review Comment:
It is, method `FileDecryptionProperties::column_key` returns an empty string
as the encryption key when the key id is not found. It should rather throw a
meaningful `key not found` exception. I may fix that while I am touching this
code anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
