pitrou commented on PR #46017: URL: https://github.com/apache/arrow/pull/46017#issuecomment-2775928216
> Is this the right direction before I roll this out to Python? Yes! > Can I break the API or should I deprecate exiting methods and provide both, std::string and secure string methods? I would rather deprecate the existing methods. > Do you have some hints how I can fix the link issues for Windows? You probably want to add a `PARQUET_EXPORT` annotation to the `SecureString` class? > Shouldn't it be sufficient to only use `OPENSSL_cleanse` and count on OpenSSL providing OS-dependent implementations? Well, currently the OpenSSL function is very crude :) https://github.com/openssl/openssl/blob/c66e00398c9feabc02ff6e678089a3dc95f985d2/crypto/mem_clr.c#L18-L25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
