EnricoMi commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2029078221
##########
cpp/src/parquet/encryption/internal_file_encryptor.h:
##########
@@ -36,7 +36,7 @@ class ColumnEncryptionProperties;
class PARQUET_EXPORT Encryptor {
public:
- Encryptor(encryption::AesEncryptor* aes_encryptor, const std::string& key,
+ Encryptor(encryption::AesEncryptor* aes_encryptor, const
encryption::SecureString& key,
const std::string& file_aad, const std::string& aad,
::arrow::MemoryPool* pool);
Review Comment:
And then move construct?
```
: aes_encryptor_(aes_encryptor),
key_(std::move(key)),
file_aad_(std::move(file_aad)),
aad_(std::move(aad)),
```
Won't that copy the arguments when calling the constructor, or will that be
optimized due to the `std::move`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
