WillAyd commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2044831701
##########
python/pyproject.toml:
##########
@@ -17,19 +17,21 @@
[build-system]
requires = [
+ "cmake < 4",
"cython >= 3",
# Starting with NumPy 1.25, NumPy is (by default) as far back compatible
# as oldest-support-numpy was (customizable with a NPY_TARGET_VERSION
# define). For older Python versions (where NumPy 1.25 is not yet
available)
# continue using oldest-support-numpy.
"oldest-supported-numpy>=0.14; python_version<'3.9'",
"numpy>=1.25; python_version>='3.9'",
+ "meson>=1.3.0",
Review Comment:
Ah OK thanks for clarifying. But wouldn't having this in the pyproject.toml
then prevent you from a situation where you have a version in your build
environment that doesn't satisfy the requirement in meson.build?
Not something I want to get hung up on, but it is also worth noting that
meson and meson-python are not attached to the same release schedule, so you
can't simply control the version of the latter to always get the functionality
from meson that you may require. See also the meson-python docs:
https://mesonbuild.com/meson-python/reference/meson-compatibility.html#meson-compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
