eli-schwartz commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2044904070
##########
python/pyproject.toml:
##########
@@ -17,19 +17,21 @@
[build-system]
requires = [
+ "cmake < 4",
"cython >= 3",
# Starting with NumPy 1.25, NumPy is (by default) as far back compatible
# as oldest-support-numpy was (customizable with a NPY_TARGET_VERSION
# define). For older Python versions (where NumPy 1.25 is not yet
available)
# continue using oldest-support-numpy.
"oldest-supported-numpy>=0.14; python_version<'3.9'",
"numpy>=1.25; python_version>='3.9'",
+ "meson>=1.3.0",
Review Comment:
> Is this necessary to enforce a minimum meson version? Again, this is a
problematic dependency for downstreams. To the best of my knowledge,
`meson-python` calls `meson` as an external executable, and we do strongly
prefer that package builds used our downstream version of `meson` rather than
installing another one for the purpose of building pyarrow.
I mused about this at
https://github.com/mesonbuild/meson-python/pull/280#issuecomment-1411507093
It would be possible for meson-python to read the version requirements from
meson.build and update `get_requires_for_*` if not detected as preinstalled at
runtime.
This would allow maintaining the minimum required version in *one* place, in
meson.build, and have it enforced everywhere.
(It appears my comment there got misinterpreted, which fair enough, I didn't
provide as much detail as I should have.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
