stayrascal commented on code in PR #324:
URL:
https://github.com/apache/arrow-rs-object-store/pull/324#discussion_r2052550930
##########
src/client/list.rs:
##########
@@ -42,86 +42,44 @@ pub(crate) trait ListClientExt {
fn list_paginated(
&self,
prefix: Option<&Path>,
- delimiter: bool,
- offset: Option<&Path>,
+ opts: ListOpts,
) -> BoxStream<'static, Result<ListResult>>;
-
- fn list(&self, prefix: Option<&Path>) -> BoxStream<'static,
Result<ObjectMeta>>;
-
- #[allow(unused)]
- fn list_with_offset(
- &self,
- prefix: Option<&Path>,
- offset: &Path,
- ) -> BoxStream<'static, Result<ObjectMeta>>;
-
- async fn list_with_delimiter(&self, prefix: Option<&Path>) ->
Result<ListResult>;
}
#[async_trait]
impl<T: ListClient + Clone> ListClientExt for T {
Review Comment:
do you mean add a `list_opts` and then calling `list_paginated` within
`list_opts` impl, and the 3 clould provider stores call
`self.client.list_opts(prefix, options)`? like this:
```
fn list_opts(
&self,
prefix: Option<&Path>,
opts: ListOpts,
) -> BoxStream<'static, Result<ListResult>> {
let client = self.clone();
client.list_paginated(prefix, opts)
}
```
The 3 clould provider are calling `list_paginated` method directly during
implementing `list_opts` of ObjectStore, because the `list_opts` of
`ListClientExt` will be very simple, just transfer request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
