tustvold commented on code in PR #324:
URL:
https://github.com/apache/arrow-rs-object-store/pull/324#discussion_r2052580940
##########
src/client/list.rs:
##########
@@ -42,86 +42,44 @@ pub(crate) trait ListClientExt {
fn list_paginated(
&self,
prefix: Option<&Path>,
- delimiter: bool,
- offset: Option<&Path>,
+ opts: ListOpts,
) -> BoxStream<'static, Result<ListResult>>;
-
- fn list(&self, prefix: Option<&Path>) -> BoxStream<'static,
Result<ObjectMeta>>;
-
- #[allow(unused)]
- fn list_with_offset(
- &self,
- prefix: Option<&Path>,
- offset: &Path,
- ) -> BoxStream<'static, Result<ObjectMeta>>;
-
- async fn list_with_delimiter(&self, prefix: Option<&Path>) ->
Result<ListResult>;
}
#[async_trait]
impl<T: ListClient + Clone> ListClientExt for T {
Review Comment:
I'm not entirely sure I follow what you are saying, but if list_paginated
ends up with the same signature as list_opts, it might as well just get renamed
to list_opts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
