stayrascal commented on code in PR #324:
URL:
https://github.com/apache/arrow-rs-object-store/pull/324#discussion_r2052552768
##########
src/client/list.rs:
##########
@@ -42,86 +42,44 @@ pub(crate) trait ListClientExt {
fn list_paginated(
&self,
prefix: Option<&Path>,
- delimiter: bool,
- offset: Option<&Path>,
+ opts: ListOpts,
) -> BoxStream<'static, Result<ListResult>>;
-
- fn list(&self, prefix: Option<&Path>) -> BoxStream<'static,
Result<ObjectMeta>>;
-
- #[allow(unused)]
- fn list_with_offset(
- &self,
- prefix: Option<&Path>,
- offset: &Path,
- ) -> BoxStream<'static, Result<ObjectMeta>>;
-
- async fn list_with_delimiter(&self, prefix: Option<&Path>) ->
Result<ListResult>;
}
#[async_trait]
impl<T: ListClient + Clone> ListClientExt for T {
fn list_paginated(
&self,
prefix: Option<&Path>,
- delimiter: bool,
- offset: Option<&Path>,
+ opts: ListOpts,
) -> BoxStream<'static, Result<ListResult>> {
+ let ListOpts {
+ delimiter,
+ offset,
+ extensions,
+ } = opts;
+
let offset = offset.map(|x| x.to_string());
let prefix = prefix
.filter(|x| !x.as_ref().is_empty())
.map(|p| format!("{}{}", p.as_ref(), crate::path::DELIMITER));
stream_paginated(
self.clone(),
- (prefix, offset),
- move |client, (prefix, offset), token| async move {
+ (prefix, offset, extensions),
+ move |client, (prefix, offset, extensions), token| async move {
let (r, next_token) = client
.list_request(
prefix.as_deref(),
delimiter,
token.as_deref(),
offset.as_deref(),
+ extensions.clone(),
)
.await?;
- Ok((r, (prefix, offset), next_token))
+ Ok((r, (prefix, offset, extensions), next_token))
},
)
.boxed()
}
-
- fn list(&self, prefix: Option<&Path>) -> BoxStream<'static,
Result<ObjectMeta>> {
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
