zhuqi-lucas commented on PR #7454: URL: https://github.com/apache/arrow-rs/pull/7454#issuecomment-2840759474
But from clickbench result, it seems performance better than the original default push down: ```rust ./bench.sh compare older_push_down test_default_parquet_push_down Comparing older_push_down and test_default_parquet_push_down -------------------- Benchmark clickbench_1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ older_push_down ┃ test_default_parquet_push_down ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.29ms │ 0.40ms │ 1.39x slower │ │ QQuery 1 │ 50.39ms │ 46.59ms │ +1.08x faster │ │ QQuery 2 │ 77.56ms │ 75.08ms │ no change │ │ QQuery 3 │ 77.95ms │ 79.83ms │ no change │ │ QQuery 4 │ 579.45ms │ 504.25ms │ +1.15x faster │ │ QQuery 5 │ 560.83ms │ 541.37ms │ no change │ │ QQuery 6 │ 0.33ms │ 0.33ms │ no change │ │ QQuery 7 │ 63.95ms │ 56.08ms │ +1.14x faster │ │ QQuery 8 │ 718.15ms │ 663.54ms │ +1.08x faster │ │ QQuery 9 │ 786.44ms │ 751.61ms │ no change │ │ QQuery 10 │ 206.47ms │ 214.36ms │ no change │ │ QQuery 11 │ 213.81ms │ 239.89ms │ 1.12x slower │ │ QQuery 12 │ 679.51ms │ 705.69ms │ no change │ │ QQuery 13 │ 1002.85ms │ 868.43ms │ +1.15x faster │ │ QQuery 14 │ 763.19ms │ 689.47ms │ +1.11x faster │ │ QQuery 15 │ 649.33ms │ 612.41ms │ +1.06x faster │ │ QQuery 16 │ 1390.12ms │ 1339.99ms │ no change │ │ QQuery 17 │ 1219.49ms │ 1134.36ms │ +1.08x faster │ │ QQuery 18 │ 2932.03ms │ 2566.26ms │ +1.14x faster │ │ QQuery 19 │ 63.44ms │ 58.59ms │ +1.08x faster │ │ QQuery 20 │ 752.05ms │ 679.10ms │ +1.11x faster │ │ QQuery 21 │ 927.06ms │ 811.46ms │ +1.14x faster │ │ QQuery 22 │ 1558.98ms │ 1461.95ms │ +1.07x faster │ │ QQuery 23 │ 3402.25ms │ 2604.51ms │ +1.31x faster │ │ QQuery 24 │ 471.04ms │ 445.48ms │ +1.06x faster │ │ QQuery 25 │ 420.43ms │ 423.96ms │ no change │ │ QQuery 26 │ 522.57ms │ 482.58ms │ +1.08x faster │ │ QQuery 27 │ 1375.58ms │ 1304.33ms │ +1.05x faster │ │ QQuery 28 │ 8767.85ms │ 8484.28ms │ no change │ │ QQuery 29 │ 458.33ms │ 446.29ms │ no change │ │ QQuery 30 │ 689.41ms │ 450.94ms │ +1.53x faster │ │ QQuery 31 │ 758.38ms │ 574.79ms │ +1.32x faster │ │ QQuery 32 │ 2981.93ms │ 2339.84ms │ +1.27x faster │ │ QQuery 33 │ 2886.54ms │ 2587.16ms │ +1.12x faster │ │ QQuery 34 │ 3298.54ms │ 2760.24ms │ +1.20x faster │ │ QQuery 35 │ 834.81ms │ 893.25ms │ 1.07x slower │ │ QQuery 36 │ 40.41ms │ 36.52ms │ +1.11x faster │ │ QQuery 37 │ 35.59ms │ 33.71ms │ +1.06x faster │ │ QQuery 38 │ 39.18ms │ 36.37ms │ +1.08x faster │ │ QQuery 39 │ 35.07ms │ 36.88ms │ 1.05x slower │ │ QQuery 40 │ 36.55ms │ 34.98ms │ no change │ │ QQuery 41 │ 36.18ms │ 36.72ms │ no change │ │ QQuery 42 │ 37.00ms │ 34.64ms │ +1.07x faster │ └──────────────┴─────────────────┴────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (older_push_down) │ 42401.30ms │ │ Total Time (test_default_parquet_push_down) │ 38148.50ms │ │ Average Time (older_push_down) │ 986.08ms │ │ Average Time (test_default_parquet_push_down) │ 887.17ms │ │ Queries Faster │ 26 │ │ Queries Slower │ 4 │ │ Queries with No Change │ 13 │ └───────────────────────────────────────────────┴────────────┘ -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ older_push_down ┃ test_default_parquet_push_down ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 1.12ms │ 1.10ms │ no change │ │ QQuery 1 │ 25.44ms │ 25.93ms │ no change │ │ QQuery 2 │ 54.65ms │ 55.48ms │ no change │ │ QQuery 3 │ 56.82ms │ 61.02ms │ 1.07x slower │ │ QQuery 4 │ 484.52ms │ 470.33ms │ no change │ │ QQuery 5 │ 524.38ms │ 546.59ms │ no change │ │ QQuery 6 │ 1.24ms │ 1.16ms │ +1.07x faster │ │ QQuery 7 │ 43.00ms │ 38.75ms │ +1.11x faster │ │ QQuery 8 │ 632.15ms │ 593.78ms │ +1.06x faster │ │ QQuery 9 │ 658.82ms │ 680.13ms │ no change │ │ QQuery 10 │ 154.14ms │ 184.81ms │ 1.20x slower │ │ QQuery 11 │ 183.86ms │ 198.64ms │ 1.08x slower │ │ QQuery 12 │ 664.23ms │ 678.02ms │ no change │ │ QQuery 13 │ 916.31ms │ 771.84ms │ +1.19x faster │ │ QQuery 14 │ 717.15ms │ 637.99ms │ +1.12x faster │ │ QQuery 15 │ 561.85ms │ 562.13ms │ no change │ │ QQuery 16 │ 1430.77ms │ 1346.40ms │ +1.06x faster │ │ QQuery 17 │ 1249.19ms │ 1117.41ms │ +1.12x faster │ │ QQuery 18 │ 2739.07ms │ 2427.62ms │ +1.13x faster │ │ QQuery 19 │ 41.63ms │ 45.73ms │ 1.10x slower │ │ QQuery 20 │ 724.72ms │ 694.00ms │ no change │ │ QQuery 21 │ 819.39ms │ 790.52ms │ no change │ │ QQuery 22 │ 1551.09ms │ 1517.14ms │ no change │ │ QQuery 23 │ 3565.46ms │ 2681.59ms │ +1.33x faster │ │ QQuery 24 │ 457.95ms │ 386.72ms │ +1.18x faster │ │ QQuery 25 │ 381.44ms │ 370.83ms │ no change │ │ QQuery 26 │ 526.80ms │ 435.73ms │ +1.21x faster │ │ QQuery 27 │ 1415.36ms │ 1354.63ms │ no change │ │ QQuery 28 │ 8528.35ms │ 9813.62ms │ 1.15x slower │ │ QQuery 29 │ 401.68ms │ 396.41ms │ no change │ │ QQuery 30 │ 728.25ms │ 431.94ms │ +1.69x faster │ │ QQuery 31 │ 744.53ms │ 528.87ms │ +1.41x faster │ │ QQuery 32 │ 3257.23ms │ 2323.61ms │ +1.40x faster │ │ QQuery 33 │ 3187.75ms │ 2517.60ms │ +1.27x faster │ │ QQuery 34 │ 3735.45ms │ 2840.70ms │ +1.31x faster │ │ QQuery 35 │ 877.66ms │ 728.25ms │ +1.21x faster │ │ QQuery 36 │ 26.23ms │ 22.64ms │ +1.16x faster │ │ QQuery 37 │ 23.04ms │ 21.68ms │ +1.06x faster │ │ QQuery 38 │ 21.55ms │ 21.89ms │ no change │ │ QQuery 39 │ 22.02ms │ 22.69ms │ no change │ │ QQuery 40 │ 21.54ms │ 21.98ms │ no change │ │ QQuery 41 │ 21.64ms │ 21.95ms │ no change │ │ QQuery 42 │ 23.77ms │ 22.51ms │ +1.06x faster │ └──────────────┴─────────────────┴────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (older_push_down) │ 42203.20ms │ │ Total Time (test_default_parquet_push_down) │ 38412.36ms │ │ Average Time (older_push_down) │ 981.47ms │ │ Average Time (test_default_parquet_push_down) │ 893.31ms │ │ Queries Faster │ 20 │ │ Queries Slower │ 5 │ │ Queries with No Change │ 18 │ └───────────────────────────────────────────────┴────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
