zhuqi-lucas commented on PR #7454: URL: https://github.com/apache/arrow-rs/pull/7454#issuecomment-2840760970
And here is the result compared with main(No push down), still some regression: ```rust ./bench.sh compare main test_default_parquet_push_down Comparing main and test_default_parquet_push_down -------------------- Benchmark clickbench_1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ test_default_parquet_push_down ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.32ms │ 0.40ms │ 1.24x slower │ │ QQuery 1 │ 46.96ms │ 46.59ms │ no change │ │ QQuery 2 │ 75.59ms │ 75.08ms │ no change │ │ QQuery 3 │ 74.12ms │ 79.83ms │ 1.08x slower │ │ QQuery 4 │ 556.03ms │ 504.25ms │ +1.10x faster │ │ QQuery 5 │ 563.52ms │ 541.37ms │ no change │ │ QQuery 6 │ 0.31ms │ 0.33ms │ 1.06x slower │ │ QQuery 7 │ 52.23ms │ 56.08ms │ 1.07x slower │ │ QQuery 8 │ 720.15ms │ 663.54ms │ +1.09x faster │ │ QQuery 9 │ 741.10ms │ 751.61ms │ no change │ │ QQuery 10 │ 171.95ms │ 214.36ms │ 1.25x slower │ │ QQuery 11 │ 187.66ms │ 239.89ms │ 1.28x slower │ │ QQuery 12 │ 597.16ms │ 705.69ms │ 1.18x slower │ │ QQuery 13 │ 877.71ms │ 868.43ms │ no change │ │ QQuery 14 │ 605.11ms │ 689.47ms │ 1.14x slower │ │ QQuery 15 │ 630.66ms │ 612.41ms │ no change │ │ QQuery 16 │ 1422.47ms │ 1339.99ms │ +1.06x faster │ │ QQuery 17 │ 1221.90ms │ 1134.36ms │ +1.08x faster │ │ QQuery 18 │ 2773.23ms │ 2566.26ms │ +1.08x faster │ │ QQuery 19 │ 66.30ms │ 58.59ms │ +1.13x faster │ │ QQuery 20 │ 682.62ms │ 679.10ms │ no change │ │ QQuery 21 │ 800.86ms │ 811.46ms │ no change │ │ QQuery 22 │ 1521.09ms │ 1461.95ms │ no change │ │ QQuery 23 │ 4223.95ms │ 2604.51ms │ +1.62x faster │ │ QQuery 24 │ 286.83ms │ 445.48ms │ 1.55x slower │ │ QQuery 25 │ 274.47ms │ 423.96ms │ 1.54x slower │ │ QQuery 26 │ 320.45ms │ 482.58ms │ 1.51x slower │ │ QQuery 27 │ 945.72ms │ 1304.33ms │ 1.38x slower │ │ QQuery 28 │ 8206.32ms │ 8484.28ms │ no change │ │ QQuery 29 │ 459.59ms │ 446.29ms │ no change │ │ QQuery 30 │ 493.35ms │ 450.94ms │ +1.09x faster │ │ QQuery 31 │ 585.82ms │ 574.79ms │ no change │ │ QQuery 32 │ 2436.43ms │ 2339.84ms │ no change │ │ QQuery 33 │ 2916.52ms │ 2587.16ms │ +1.13x faster │ │ QQuery 34 │ 2975.16ms │ 2760.24ms │ +1.08x faster │ │ QQuery 35 │ 866.75ms │ 893.25ms │ no change │ │ QQuery 36 │ 104.22ms │ 36.52ms │ +2.85x faster │ │ QQuery 37 │ 62.50ms │ 33.71ms │ +1.85x faster │ │ QQuery 38 │ 107.57ms │ 36.37ms │ +2.96x faster │ │ QQuery 39 │ 167.64ms │ 36.88ms │ +4.55x faster │ │ QQuery 40 │ 46.49ms │ 34.98ms │ +1.33x faster │ │ QQuery 41 │ 45.49ms │ 36.72ms │ +1.24x faster │ │ QQuery 42 │ 42.51ms │ 34.64ms │ +1.23x faster │ └──────────────┴───────────┴────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main) │ 39956.84ms │ │ Total Time (test_default_parquet_push_down) │ 38148.50ms │ │ Average Time (main) │ 929.23ms │ │ Average Time (test_default_parquet_push_down) │ 887.17ms │ │ Queries Faster │ 17 │ │ Queries Slower │ 12 │ │ Queries with No Change │ 14 │ └───────────────────────────────────────────────┴────────────┘ -------------------- Benchmark clickbench_partitioned.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ test_default_parquet_push_down ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 1.10ms │ 1.10ms │ no change │ │ QQuery 1 │ 24.27ms │ 25.93ms │ 1.07x slower │ │ QQuery 2 │ 58.03ms │ 55.48ms │ no change │ │ QQuery 3 │ 58.91ms │ 61.02ms │ no change │ │ QQuery 4 │ 478.56ms │ 470.33ms │ no change │ │ QQuery 5 │ 549.38ms │ 546.59ms │ no change │ │ QQuery 6 │ 1.18ms │ 1.16ms │ no change │ │ QQuery 7 │ 40.05ms │ 38.75ms │ no change │ │ QQuery 8 │ 645.79ms │ 593.78ms │ +1.09x faster │ │ QQuery 9 │ 671.10ms │ 680.13ms │ no change │ │ QQuery 10 │ 133.89ms │ 184.81ms │ 1.38x slower │ │ QQuery 11 │ 159.81ms │ 198.64ms │ 1.24x slower │ │ QQuery 12 │ 561.74ms │ 678.02ms │ 1.21x slower │ │ QQuery 13 │ 750.14ms │ 771.84ms │ no change │ │ QQuery 14 │ 525.03ms │ 637.99ms │ 1.22x slower │ │ QQuery 15 │ 553.88ms │ 562.13ms │ no change │ │ QQuery 16 │ 1417.77ms │ 1346.40ms │ +1.05x faster │ │ QQuery 17 │ 1104.70ms │ 1117.41ms │ no change │ │ QQuery 18 │ 3037.46ms │ 2427.62ms │ +1.25x faster │ │ QQuery 19 │ 45.81ms │ 45.73ms │ no change │ │ QQuery 20 │ 733.71ms │ 694.00ms │ +1.06x faster │ │ QQuery 21 │ 789.70ms │ 790.52ms │ no change │ │ QQuery 22 │ 1299.84ms │ 1517.14ms │ 1.17x slower │ │ QQuery 23 │ 3952.24ms │ 2681.59ms │ +1.47x faster │ │ QQuery 24 │ 273.40ms │ 386.72ms │ 1.41x slower │ │ QQuery 25 │ 274.14ms │ 370.83ms │ 1.35x slower │ │ QQuery 26 │ 320.12ms │ 435.73ms │ 1.36x slower │ │ QQuery 27 │ 900.06ms │ 1354.63ms │ 1.51x slower │ │ QQuery 28 │ 7812.82ms │ 9813.62ms │ 1.26x slower │ │ QQuery 29 │ 390.07ms │ 396.41ms │ no change │ │ QQuery 30 │ 420.68ms │ 431.94ms │ no change │ │ QQuery 31 │ 571.58ms │ 528.87ms │ +1.08x faster │ │ QQuery 32 │ 2585.80ms │ 2323.61ms │ +1.11x faster │ │ QQuery 33 │ 2621.59ms │ 2517.60ms │ no change │ │ QQuery 34 │ 3144.83ms │ 2840.70ms │ +1.11x faster │ │ QQuery 35 │ 855.71ms │ 728.25ms │ +1.18x faster │ │ QQuery 36 │ 80.10ms │ 22.64ms │ +3.54x faster │ │ QQuery 37 │ 35.71ms │ 21.68ms │ +1.65x faster │ │ QQuery 38 │ 79.06ms │ 21.89ms │ +3.61x faster │ │ QQuery 39 │ 123.78ms │ 22.69ms │ +5.46x faster │ │ QQuery 40 │ 29.03ms │ 21.98ms │ +1.32x faster │ │ QQuery 41 │ 27.67ms │ 21.95ms │ +1.26x faster │ │ QQuery 42 │ 25.98ms │ 22.51ms │ +1.15x faster │ └──────────────┴───────────┴────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main) │ 38166.21ms │ │ Total Time (test_default_parquet_push_down) │ 38412.36ms │ │ Average Time (main) │ 887.59ms │ │ Average Time (test_default_parquet_push_down) │ 893.31ms │ │ Queries Faster │ 16 │ │ Queries Slower │ 11 │ │ Queries with No Change │ 16 │ └───────────────────────────────────────────────┴────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
