Re: [PR] Draft Poc for Unified select (Enum for bitmap and range) [arrow-rs]

[via GitHub]

zhuqi-lucas commented on PR #7454:
URL: https://github.com/apache/arrow-rs/pull/7454#issuecomment-2849977053

   > I take Q27 for example, it looks like the regression still comes from 
decompress, even the page cache case, it still use more decompress time, which 
cause the regression. We need to investigate more about the regression.
   > 
   > 1. The no pushdown case:
   >    
![flamegraphFast](https://private-user-images.githubusercontent.com/12184649/439067892-761f7bfd-8b25-4508-9d98-2aa98ca94fc9.svg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY0MjQ1NDMsIm5iZiI6MTc0NjQyNDI0MywicGF0aCI6Ii8xMjE4NDY0OS80MzkwNjc4OTItNzYxZjdiZmQtOGIyNS00NTA4LTlkOTgtMmFhOThjYTk0ZmM5LnN2Zz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTA1VDA1NTA0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBiNmIzYzYxNGE3MWYxOGM0ZWQ0MTU2NDI3MTc5ZDg0MTVjOWYyNjMxY2E3MGQxZGU2OWNlNmJlODc1MTY1ZTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wRDwQ21DxVhE4nQjtUgIvKaqgwhixoIg25ZRA7eQsYE)
   > 2. The page cache case:
   > 
   > 
![flamegraphPageCache](https://private-user-images.githubusercontent.com/12184649/439067930-e15a6313-c1df-466c-a2df-e7a367ceca4b.svg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY0MjQ1NDMsIm5iZiI6MTc0NjQyNDI0MywicGF0aCI6Ii8xMjE4NDY0OS80MzkwNjc5MzAtZTE1YTYzMTMtYzFkZi00NjZjLWEyZGYtZTdhMzY3Y2VjYTRiLnN2Zz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTA1VDA1NTA0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIxYWFjNzY3NGQ5OTMxYWE5MjJmZGM4NGVmYjYzYzQwOWYzMjQyMDhhM2M4YWE5NTAwZjQ4OGM2ZWYwOTBiM2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.muKVJ9LkouDWS-0xBQJrNtH3ResW0Dnn0vzGQLSbE1M)
   > 
   > 3. Current PR case:
   >    
![flamegraphSlow](https://private-user-images.githubusercontent.com/12184649/439068048-bf323caf-01a1-43e8-b680-20d04c648f05.svg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY0MjQ1NDMsIm5iZiI6MTc0NjQyNDI0MywicGF0aCI6Ii8xMjE4NDY0OS80MzkwNjgwNDgtYmYzMjNjYWYtMDFhMS00M2U4LWI2ODAtMjBkMDRjNjQ4ZjA1LnN2Zz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTA1VDA1NTA0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThkOTRlOWE2Yjk5NzZlMWQyOTJmMGZkNzJmMTVlMWMyNGU2NmRkYjZiNmY1Y2NlOWNjY2UyM2JmN2ZkYzI4NDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QrSY2vSjJMD1BbJ9eYwHn-0AqVMwIyEnH8c-QKH6yOI)
   
   
   
   Updated, after investigation, i found the root cause for page cache PR use 
more time to decode pages, i will try to update the polish_page_cache PR to 
address the changes, i hope we can solve all the regression for the page cache.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org