hiroyuki-sato commented on code in PR #46305:
URL: https://github.com/apache/arrow/pull/46305#discussion_r2072527506
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -2267,6 +2269,37 @@ garrow_string_view_data_type_new(void)
return data_type;
}
+G_DEFINE_TYPE(GArrowFixedShapeTensorDataType,
+ garrow_fixed_shape_tensor_data_type,
+ GARROW_TYPE_EXTENSION_DATA_TYPE)
+
+static void
+garrow_fixed_shape_tensor_data_type_init(GArrowFixedShapeTensorDataType
*object)
+{
+}
+
+static void
+garrow_fixed_shape_tensor_data_type_class_init(GArrowFixedShapeTensorDataTypeClass
*klass)
+{
+}
+
+/**
+ * garrow_fixed_shape_tensor_data_type_new:
+ *
+ * Returns: The newly created fixed shape tensor data type.
+ */
+GArrowFixedShapeTensorDataType *
+garrow_fixed_shape_tensor_data_type_new(void)
+{
+ auto arrow_data_type = arrow::GetExtensionType("arrow.fixed_shape_tensor");
Review Comment:
Could you check this part correct?
Maybe we need to use this?
```cpp
/// \brief Return a FixedShapeTensorType instance.
ARROW_EXPORT std::shared_ptr<DataType> fixed_shape_tensor(
const std::shared_ptr<DataType>& storage_type, const
std::vector<int64_t>& shape,
const std::vector<int64_t>& permutation = {},
const std::vector<std::string>& dim_names = {});
```
If, so the function declaration should be like the following?
```cpp
garrow_fixed_shape_tensor_data_type_new(GArrowDataType *stoarge_type,
GList *shape,
GList *permutation,
GList *dim_names)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
