kou commented on code in PR #46305:
URL: https://github.com/apache/arrow/pull/46305#discussion_r2072534473
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -2267,6 +2269,37 @@ garrow_string_view_data_type_new(void)
return data_type;
}
+G_DEFINE_TYPE(GArrowFixedShapeTensorDataType,
+ garrow_fixed_shape_tensor_data_type,
+ GARROW_TYPE_EXTENSION_DATA_TYPE)
+
+static void
+garrow_fixed_shape_tensor_data_type_init(GArrowFixedShapeTensorDataType
*object)
+{
+}
+
+static void
+garrow_fixed_shape_tensor_data_type_class_init(GArrowFixedShapeTensorDataTypeClass
*klass)
+{
+}
+
+/**
+ * garrow_fixed_shape_tensor_data_type_new:
+ *
+ * Returns: The newly created fixed shape tensor data type.
+ */
+GArrowFixedShapeTensorDataType *
+garrow_fixed_shape_tensor_data_type_new(void)
+{
+ auto arrow_data_type = arrow::GetExtensionType("arrow.fixed_shape_tensor");
Review Comment:
We need to accept `value_type`, `size`, `shape`, `permutation` and
`dimension_names` and use `std::make_shared<arrow::FixedShapeTensorType(...)`
instead of `arrow::GetExtensionType(...)`.
See also:
https://github.com/apache/arrow/blob/068416bd411d6a8e2949f8ebcb2f80e2c302ef6b/cpp/src/arrow/extension/fixed_shape_tensor.h#L55-L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
