hiroyuki-sato commented on code in PR #46305:
URL: https://github.com/apache/arrow/pull/46305#discussion_r2075475399
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -2267,6 +2269,37 @@ garrow_string_view_data_type_new(void)
return data_type;
}
+G_DEFINE_TYPE(GArrowFixedShapeTensorDataType,
+ garrow_fixed_shape_tensor_data_type,
+ GARROW_TYPE_EXTENSION_DATA_TYPE)
+
+static void
+garrow_fixed_shape_tensor_data_type_init(GArrowFixedShapeTensorDataType
*object)
+{
+}
+
+static void
+garrow_fixed_shape_tensor_data_type_class_init(GArrowFixedShapeTensorDataTypeClass
*klass)
+{
+}
+
+/**
+ * garrow_fixed_shape_tensor_data_type_new:
+ *
+ * Returns: The newly created fixed shape tensor data type.
+ */
+GArrowFixedShapeTensorDataType *
+garrow_fixed_shape_tensor_data_type_new(void)
+{
+ auto arrow_data_type = arrow::GetExtensionType("arrow.fixed_shape_tensor");
Review Comment:
`permutation` and `dim_names` allows empty. Do we need to add `(nullable)`
annotation?
```diff
diff --git a/c_glib/arrow-glib/basic-data-type.cpp
b/c_glib/arrow-glib/basic-data-type.cpp
index 2f547ee60..012562828 100644
--- a/c_glib/arrow-glib/basic-data-type.cpp
+++ b/c_glib/arrow-glib/basic-data-type.cpp
@@ -2291,11 +2291,11 @@
garrow_fixed_shape_tensor_data_type_class_init(GArrowFixedShapeTensorDataTypeCla
* @shape: (array length=shape_length): A physical shape of the contained
tensors as an
* array.
* @shape_length: The length of `shape`.
- * @permutation: (array length=permutation_length): An indices of the
desired ordering of
+ * @permutation: (array length=permutation_length) (nullable): An indices
of the desired ordering of
* the original dimensions, defined as an array. This must be `NULL` or the
same length
* array of `shape`.
* @permutation_length: The length of `permutation`.
- * @dim_names: (array length=n_dim_names): Explicit names to tensor
dimensions as an
+ * @dim_names: (array length=n_dim_names) (nullable): Explicit names to
tensor dimensions as an
* array. This must be `NULL` or the same length array of `shape`.
* @n_dim_names. The length of `dim_names`.
* @error: (nullable): Return location for a #GError or %NULL.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
