zanmato1984 commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2076586295
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -639,12 +639,8 @@ class InputState : public
util::SerialSequencingQueue::Processor {
// hit the end of the batch, need to get the next batch if possible.
++batches_processed_;
latest_ref_row_ = 0;
- have_active_batch &= !queue_.TryPop();
Review Comment:
I noticed there are two fixes made before in the following `if` branch
#36094 and #36499. Given that this `have_active_batch &= !queue_.TryPop()`
exists since #13028 where it was introduced, and the lack of corresponding
tests, I'm not sure how they fixed anything and what the bugs even were. So I
just remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
