zanmato1984 commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2078138687
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -639,12 +639,8 @@ class InputState : public
util::SerialSequencingQueue::Processor {
// hit the end of the batch, need to get the next batch if possible.
++batches_processed_;
latest_ref_row_ = 0;
- have_active_batch &= !queue_.TryPop();
- if (have_active_batch) {
- DCHECK_GT(queue_.Front()->num_rows(), 0); // empty batches
disallowed
- memo_.UpdateTime(GetTime(queue_.Front().get(), time_type_id_,
time_col_index_,
- 0)); // time changed
- }
+ std::ignore = queue_.TryPop();
Review Comment:
This is definitely a good point, will do. Thank you!
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1770,5 +1771,38 @@ TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
DeclarationToStatus(std::move(sink)));
}
+// Reproduction of GH-46224: Hang when all left timestamps are greater than
right
+// timestamps.
Review Comment:
Yeah, sure, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
