pitrou commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2084228040


##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1770,5 +1771,53 @@ TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
       DeclarationToStatus(std::move(sink)));
 }
 
+// Reproduction of GH-46224: Hang when all left timestamps are greater than 
right
+// timestamps.
+TEST(AsofJoinTest, OneSideTsAllGreaterThanTheOther) {

Review Comment:
   Just one thing: I see that it takes around 8s on a regular debug build (on 
my machine anyway). Should we make sure that it's not too costly under Valgrind?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to