kou commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2096884974
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4845,6 +4845,14 @@ macro(build_opentelemetry)
version)
set(OPENTELEMETRY_BUILD_BYPRODUCTS)
set(OPENTELEMETRY_LIBRARIES)
+ set(OPENTELEMETRY_CXX_FLAGS "${EP_CXX_FLAGS}")
+ # GH-46508: Supress warnings that won't be demoted by -Wno-error in recent
Clang.
+ if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND
+ CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "19.1.0") OR
+ (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND
+ CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "17.0.0"))
+ string(APPEND OPENTELEMETRY_CXX_FLAGS "
-Wno-error=missing-template-arg-list-after-template-kw")
+ endif()
Review Comment:
Can we always omit `-Werror` in OpenTelemetry C++? In general, we don't want
to enable `-Werror` for bundled dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
