zanmato1984 commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2096896367
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4845,6 +4845,14 @@ macro(build_opentelemetry)
version)
set(OPENTELEMETRY_BUILD_BYPRODUCTS)
set(OPENTELEMETRY_LIBRARIES)
+ set(OPENTELEMETRY_CXX_FLAGS "${EP_CXX_FLAGS}")
+ # GH-46508: Supress warnings that won't be demoted by -Wno-error in recent
Clang.
+ if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND
+ CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "19.1.0") OR
+ (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND
+ CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "17.0.0"))
+ string(APPEND OPENTELEMETRY_CXX_FLAGS "
-Wno-error=missing-template-arg-list-after-template-kw")
+ endif()
Review Comment:
Thank you @kou . But omitting `-Werror` doesn't suppress this error. I'm not
exactly sure how this warning as error works but here are some godbolt
experiments showing only
`-Wno-error=missing-template-arg-list-after-template-kw` would work.
No `-Werror` (error): https://godbolt.org/z/8bMdPEaoE
Solely `-Wno-error` (error): https://godbolt.org/z/f7KW3MsP5
Solely `-Wno-error=missing-template-arg-list-after-template-kw` (ok):
https://godbolt.org/z/bf3Gds85n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
