zanmato1984 commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2097074092
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4845,6 +4845,14 @@ macro(build_opentelemetry)
version)
set(OPENTELEMETRY_BUILD_BYPRODUCTS)
set(OPENTELEMETRY_LIBRARIES)
+ set(OPENTELEMETRY_CXX_FLAGS "${EP_CXX_FLAGS}")
+ # GH-46508: Supress warnings that won't be demoted by -Wno-error in recent
Clang.
+ if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND
+ CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "19.1.0") OR
+ (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND
+ CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "17.0.0"))
+ string(APPEND OPENTELEMETRY_CXX_FLAGS "
-Wno-error=missing-template-arg-list-after-template-kw")
+ endif()
Review Comment:
The latest opentelemetry-cpp doesn't have this error, only that we need a
small tweak to override a virtual method that has been made pure virtual in
recent version - not a big deal though.
I made the change in [`8a718df`
(#46509)](https://github.com/apache/arrow/pull/46509/commits/8a718dfa328ee847dbb44a8b30ae8b56355b7e71)
, which has been verified to be working w/o the previous changes (the compiler
options). I'm keeping both fixes temporarily for you to choose which is
preferable and will remove the other once we settled on one. I personally think
upgrading to latest makes more sense.
@kou PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
