zanmato1984 commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2114330692


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4849,6 +4849,7 @@ macro(build_opentelemetry)
       version)
   set(OPENTELEMETRY_BUILD_BYPRODUCTS)
   set(OPENTELEMETRY_LIBRARIES)
+  set(OPENTELEMETRY_CXX_FLAGS "${EP_CXX_FLAGS}")

Review Comment:
   Shall keep this anyway.



##########
cpp/build-support/sanitizer-disallowed-entries.txt:
##########
@@ -23,3 +23,7 @@ fun:*testing*internal*InvokeWith*
 
 # Workaround for RapidJSON https://github.com/Tencent/rapidjson/issues/1724
 src:*/rapidjson/internal/*
+

Review Comment:
   To be removed, not working.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to