zanmato1984 commented on PR #46509: URL: https://github.com/apache/arrow/pull/46509#issuecomment-2926057696
I found it nearly impossible to suppress this false-positive "heap-use-after-free" ASAN error caused by partial instrumentation. I think we have three options now: 1. Also instrument bundled opentelemetry (another odr violation error jumps but it's trivially suppress-able). Several concerns though: 1) do we want to also instrument other bundled dependencies? 2) for ASAN only or for other sanitizers as well? 3) this doesn't prevent false-positives from system installed dependencies (but I think this should be fine because it's likely only our CI uses sanitizers). 2. Upgrade opentelemetry-cpp to a less recent version, e.g. 1.19, which is prior the [commit](https://github.com/open-telemetry/opentelemetry-cpp/commit/52a80b5a04cd21d0528d086556ce5465b9e31564) that introduced the false-positive code and after the [commit](https://github.com/open-telemetry/opentelemetry-cpp/commit/95d039c08a4091e6543a0f26650a0a9315eef279) fixed the recent compile issue. The concern is this is unsustainable. 3. Simply disable the tests in question for ASAN. I personally vote for 3. What's your thought @kou ? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
