kou commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2120154660
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
Review Comment:
Can we revert changes in this file?
##########
cpp/build-support/tsan-suppressions.txt:
##########
@@ -17,3 +17,6 @@
# Thread leak in CUDA
thread:libcuda.so
+
+# False-positives in OpenTelemetry because of non-instrumented code.
+race:^opentelemetry
Review Comment:
Do we still need this?
(Is ASAN only disabled?)
##########
cpp/build-support/lsan-suppressions.txt:
##########
@@ -26,3 +26,4 @@ leak:CRYPTO_zalloc
# without LSAN_OPTIONS=fast_unwind_on_malloc=0:malloc_context_size=100
leak:opentelemetry::v1::context::ThreadLocalContextStorage::GetStack
leak:opentelemetry::v1::context::ThreadLocalContextStorage::Stack::Resize
+leak:std::make_shared<opentelemetry::v1::trace::NoopTracer>
Review Comment:
Do we still need this?
(Is ASAN only disabled?)
##########
cpp/build-support/run-test.sh:
##########
@@ -75,10 +75,9 @@ function setup_sanitizers() {
UBSAN_OPTIONS="$UBSAN_OPTIONS
suppressions=$ROOT/build-support/ubsan-suppressions.txt"
export UBSAN_OPTIONS
- # Enable leak detection even under LLVM 3.4, where it was disabled by
default.
- # This flag only takes effect when running an ASAN build.
- # ASAN_OPTIONS="$ASAN_OPTIONS detect_leaks=1"
- # export ASAN_OPTIONS
+ # Set up suppressions for AddressSanitizer
+ ASAN_OPTIONS="$ASAN_OPTIONS
suppressions=$ROOT/build-support/asan-suppressions.txt"
+ export ASAN_OPTIONS
Review Comment:
Could you revert ASAN related changes for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
