WillAyd commented on code in PR #770:
URL: https://github.com/apache/arrow-nanoarrow/pull/770#discussion_r2135757701
##########
src/nanoarrow/nanoarrow_testing.hpp:
##########
@@ -272,9 +268,9 @@ class NANOARROW_DLL TestingJSONComparison {
TestingJSONWriter writer_actual_;
TestingJSONWriter writer_expected_;
std::vector<Difference> differences_;
- nanoarrow::UniqueSchema schema_;
- nanoarrow::UniqueArrayView actual_;
- nanoarrow::UniqueArrayView expected_;
+ struct ArrowSchema schema_;
Review Comment:
Maybe we should export the UniqueXXX classes? They are intended for use in
downstream applications, no?
##########
src/nanoarrow/nanoarrow_testing.hpp:
##########
@@ -193,18 +192,15 @@ class NANOARROW_DLL TestingJSONReader {
class NANOARROW_DLL TestingJSONComparison {
private:
// Internal representation of a human-readable inequality
- struct Difference {
+ struct NANOARROW_DLL Difference {
Review Comment:
Definitely not an expert on the rules here (especially with Windows in the
mix) but I wanted to double check this is actually required. It feels strange
to have to export a private nested struct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
