paleolimbot commented on code in PR #770:
URL: https://github.com/apache/arrow-nanoarrow/pull/770#discussion_r2135840317
##########
src/nanoarrow/nanoarrow_testing.hpp:
##########
@@ -272,9 +268,9 @@ class NANOARROW_DLL TestingJSONComparison {
TestingJSONWriter writer_actual_;
TestingJSONWriter writer_expected_;
std::vector<Difference> differences_;
- nanoarrow::UniqueSchema schema_;
- nanoarrow::UniqueArrayView actual_;
- nanoarrow::UniqueArrayView expected_;
+ struct ArrowSchema schema_;
Review Comment:
I think we can't at the moment because we don't have a C++ runtime library
(it's all headers), but I also think their intended usage works: as long as
they are not exposed in such a way that a calling library would need to know
how to delete them it is OK. I think in real life one would just statically
link nanoarrow on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
