paleolimbot commented on code in PR #770:
URL: https://github.com/apache/arrow-nanoarrow/pull/770#discussion_r2135841622
##########
src/nanoarrow/nanoarrow_testing.hpp:
##########
@@ -193,18 +192,15 @@ class NANOARROW_DLL TestingJSONReader {
class NANOARROW_DLL TestingJSONComparison {
private:
// Internal representation of a human-readable inequality
- struct Difference {
+ struct NANOARROW_DLL Difference {
Review Comment:
I agree that it feel strange! It is needed (or else I get the same dll
interface required note).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
