khwilson commented on PR #44184: URL: https://github.com/apache/arrow/pull/44184#issuecomment-2954279621
OK, @zanmato1984 added the tests and updated docs. For the SFINAE things, a couple considerations: * Probably isn't super critical for performance, but... * In the grouped aggregators, `GetOutType` is `static` so creating class-level (e.g., `GroupedMeanImpl`) runtime differences would likely require refactoring `GetOutType`. Given the second bullet, I'd keep it as SFINAE for consistency between the two implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
