scovich commented on code in PR #7720:
URL: https://github.com/apache/arrow-rs/pull/7720#discussion_r2160076955
##########
parquet-variant/src/builder.rs:
##########
@@ -540,7 +535,8 @@ impl<'a> ObjectBuilder<'a> {
}
// Write field offsets
- for &(_, offset) in &self.fields {
+ for id in self.parent.dict.values() {
+ let &offset = self.fields.get(id).unwrap();
Review Comment:
I'm not sure it's really helpful to optimize a known dead end path -- we
have to figure out something that works for nested arrays and objects -- but
maybe that's just me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
