friendlymatthew commented on code in PR #7720:
URL: https://github.com/apache/arrow-rs/pull/7720#discussion_r2160078731
##########
parquet-variant/src/builder.rs:
##########
@@ -540,7 +535,8 @@ impl<'a> ObjectBuilder<'a> {
}
// Write field offsets
- for &(_, offset) in &self.fields {
+ for id in self.parent.dict.values() {
+ let &offset = self.fields.get(id).unwrap();
Review Comment:
Yeah I agree and fwiw, I included a change in this PR to remove this 1:1
object builder field names to metadata dictionary assumption.
We now do something like:
```rs
let field_ids_by_sorted_field_name = self
.parent
.dict
.iter()
.filter_map(|(_, id)|
self.fields.contains_key(id).then_some(*id))
.collect::<Vec<_>>();
```
which will work with nested objects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
