friendlymatthew commented on PR #7720: URL: https://github.com/apache/arrow-rs/pull/7720#issuecomment-2994196078
> I am not sure about returning an error on `append_value` > > Also, while typing this it seems like `ObjectBuilder::append_value` is a somewhat strange name -- maybe it would be better to be called `append_field` or `insert` or something 🤔 (for a different PR) I got too excited and decided to add the duplicate field name check to this PR. I'm happy to roll that commit back and merge this PR as strictly a `BTreeMap` change, and then push up a following PR with the method name change + the duplicate field name check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
