andishgar commented on code in PR #46779:
URL: https://github.com/apache/arrow/pull/46779#discussion_r2173216619
##########
cpp/src/arrow/record_batch.h:
##########
@@ -120,6 +120,10 @@ class ARROW_EXPORT RecordBatch {
/// \brief Determine if two record batches are exactly equal
///
+ /// Setting \ref arrow::EqualOptions::use_atol to true is equivalent to
+ /// using \ref arrow::RecordBatch::ApproxEquals Although, Schema comparison
is included,
Review Comment:
According to this
[link](https://www.writewithjean.com/usage-and-grammar/although/), it seems
I've been misusing "although."
> [!NOTE]
**Never put a comma after although.
Beware of writing something like this:
I decided to accept the job offer. Although, I had some doubts about the
company’s stability. INCORRECT
Here’s the correct version:
I decided to accept the job offer although I had some doubts about the
company’s stability. CORRECT**
>
Also, based on this [link](https://www.pristineword.com/comma-although/), it
seems that when "although" doesn't introduce a strong contrast, a comma isn't
necessary—so I’ve been using it incorrectly there too. :)
> [!NOTE]
**In the middle of a sentence, you can omit the comma if there is not a
clear contrast between both clauses.**
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
