kou commented on code in PR #46779:
URL: https://github.com/apache/arrow/pull/46779#discussion_r2174035197
##########
cpp/src/arrow/array/statistics_test.cc:
##########
@@ -148,8 +148,9 @@ TEST_F(TestArrayStatisticsEqualityDoubleValue, NaN) {
TEST_F(TestArrayStatisticsEqualityDoubleValue, ApproximateEquals) {
statistics1_.max = 0.5001f;
statistics2_.max = 0.5;
- ASSERT_FALSE(statistics1_.Equals(statistics2_,
options_.atol(1e-3).use_atol(false)));
- ASSERT_TRUE(statistics1_.Equals(statistics2_, options_.atol(1e-3)));
+
Review Comment:
```suggestion
```
##########
cpp/src/arrow/chunked_array_test.cc:
##########
@@ -181,7 +181,17 @@ TEST_F(TestChunkedArray, EqualsSameAddressWithNaNs) {
ASSERT_OK_AND_ASSIGN(auto chunked_array_without_nan2,
ChunkedArray::Make(chunks4));
ASSERT_TRUE(chunked_array_without_nan2->Equals(chunked_array_without_nan2));
}
-
+TEST_F(TestChunkedArray, ApproxEquals) {
+ auto chunk_1 = ArrayFromJSON(float64(), R"([0.0, 0.1, 0.5])");
+ auto chunk_2 = ArrayFromJSON(float64(), R"([0.0, 0.1, 0.5001])");
+ ASSERT_OK_AND_ASSIGN(auto chunked_array_1, ChunkedArray::Make({chunk_1}));
+ ASSERT_OK_AND_ASSIGN(auto chunked_array_2, ChunkedArray::Make({chunk_2}));
+ auto options = EqualOptions::Defaults().atol(1e-3);
+
+ ASSERT_FALSE(chunked_array_1->Equals(chunked_array_2));
+ ASSERT_TRUE(chunked_array_1->Equals(chunked_array_2,
options.use_atol(true)));
+ ASSERT_TRUE(chunked_array_1->ApproxEquals(*chunked_array_2, options));
+}
Review Comment:
```suggestion
}
```
##########
cpp/src/arrow/chunked_array_test.cc:
##########
@@ -181,7 +181,17 @@ TEST_F(TestChunkedArray, EqualsSameAddressWithNaNs) {
ASSERT_OK_AND_ASSIGN(auto chunked_array_without_nan2,
ChunkedArray::Make(chunks4));
ASSERT_TRUE(chunked_array_without_nan2->Equals(chunked_array_without_nan2));
}
-
+TEST_F(TestChunkedArray, ApproxEquals) {
Review Comment:
```suggestion
TEST_F(TestChunkedArray, ApproxEquals) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
