andishgar commented on PR #46779: URL: https://github.com/apache/arrow/pull/46779#issuecomment-3015334293
@kou I think the following test is broken: https://github.com/apache/arrow/blob/ed13cedd8bf7ddc06db152f97e68d86c2c37e949/cpp/src/arrow/chunked_array_test.cc#L156-L183 If the intention is to test [this condition](https://github.com/apache/arrow/blob/ed13cedd8bf7ddc06db152f97e68d86c2c37e949/cpp/src/arrow/compare.cc#L702-L705), the expression will always evaluate to false. This is because new `arrow::ArrayData instances` are created during chunk comparisons, as shown here: https://github.com/apache/arrow/blob/ed13cedd8bf7ddc06db152f97e68d86c2c37e949/cpp/src/arrow/chunked_array.cc#L329-L330 1-Is my understanding correct? 2- Should I open a separate issue and add a TODO above the test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
