friendlymatthew commented on PR #7871: URL: https://github.com/apache/arrow-rs/pull/7871#issuecomment-3039112429
> note: moving and changing code in the same commit makes review a lot more difficult, and refactor + bug fix in the same commit suffers a similar issue. I know this code inside out and it's still hard to be sure I'm catching everything -- imagine the burden on a reviewer who isn't as familiar with the code? That makes a lot of sense to me. Fwiw, I was reviewing my diff last night and noticed the code movement obfuscates the diff quite significantly. The PR is now split into three commits, with each phase introducing another refactor. 1. Code movement 2. Rename symbols 3. The actual bug fixes Thank you for the tip @scovich 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
