scovich commented on code in PR #7871:
URL: https://github.com/apache/arrow-rs/pull/7871#discussion_r2187902028
##########
parquet-variant/src/variant/object.rs:
##########
@@ -197,22 +197,22 @@ impl<'m, 'v> VariantObject<'m, 'v> {
/// True if this instance is fully [validated] for panic-free infallible
accesses.
///
/// [validated]: Self#Validation
- pub fn is_validated(&self) -> bool {
+ pub fn is_fully_validated(&self) -> bool {
self.validated
}
/// Performs a full [validation] of this variant object.
///
/// [validation]: Self#Validation
- pub fn validate(mut self) -> Result<Self, ArrowError> {
+ pub fn with_full_validation(mut self) -> Result<Self, ArrowError> {
if !self.validated {
// Validate the metadata dictionary first, if not already
validated, because we pass it
// by value to all the children (who would otherwise re-validate
it repeatedly).
- self.metadata = self.metadata.validate()?;
+ self.metadata = self.metadata.with_full_validation()?;
// Iterate over all string keys in this dictionary in order to
prove that the offset
// array is valid, all offsets are in bounds, and all string bytes
are valid utf-8.
- validate_fallible_iterator(self.iter_try_impl())?;
+
validate_fallible_iterator(self.iter_try_with_shallow_validation())?;
self.validated = true;
}
Ok(self)
Review Comment:
NOTE: That will probably slow things down again (because currently we're
_not_ performing the validation we claimed). But that's fine as long as it's
linear (and reasonable) cost.
##########
parquet-variant/src/variant/object.rs:
##########
@@ -197,22 +197,22 @@ impl<'m, 'v> VariantObject<'m, 'v> {
/// True if this instance is fully [validated] for panic-free infallible
accesses.
///
/// [validated]: Self#Validation
- pub fn is_validated(&self) -> bool {
+ pub fn is_fully_validated(&self) -> bool {
self.validated
}
/// Performs a full [validation] of this variant object.
///
/// [validation]: Self#Validation
- pub fn validate(mut self) -> Result<Self, ArrowError> {
+ pub fn with_full_validation(mut self) -> Result<Self, ArrowError> {
if !self.validated {
// Validate the metadata dictionary first, if not already
validated, because we pass it
// by value to all the children (who would otherwise re-validate
it repeatedly).
- self.metadata = self.metadata.validate()?;
+ self.metadata = self.metadata.with_full_validation()?;
// Iterate over all string keys in this dictionary in order to
prove that the offset
// array is valid, all offsets are in bounds, and all string bytes
are valid utf-8.
- validate_fallible_iterator(self.iter_try_impl())?;
+
validate_fallible_iterator(self.iter_try_with_shallow_validation())?;
self.validated = true;
}
Ok(self)
Review Comment:
NOTE: Fixing that will probably slow things down again (because currently
we're _not_ performing the validation we claimed). But that's fine as long as
it's linear (and reasonable) cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
