friendlymatthew commented on PR #7871: URL: https://github.com/apache/arrow-rs/pull/7871#issuecomment-3040521102
> > ... at least, confident we caught all the ones in code paths this specific unit test exercises. But it's tricky -- I tried to make a visual sweep of all `XXX_with_shallow_validation` methods and didn't notice anything else. But then I re-ran the unit test "benchmark" and saw that it was still oddly slow. Found the third missed site during a second, more motivated, code inspection pass. > > Can we make your test into an actual benchmark (aka something like https://github.com/apache/arrow-rs/blob/main/parquet-variant/benches/variant_builder.rs )? Hi, I have an ad-hoc benchmark that lives [here](https://github.com/apache/arrow-rs/compare/main...pydantic:arrow-rs:friendlymatthew/bench-validation-large-json). It uses the same logic in `test_json_to_variant_object_very_large` to build up the object. The validation logic on main regresses quite significantly when compared to the validation logic in this PR <img width="859" alt="Screenshot 2025-07-05 at 9 34 19 PM" src="https://github.com/user-attachments/assets/62515dbc-4bc9-4541-9b36-b22f0089fadb"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
