toddmeng-db commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2244166363
##########
csharp/src/Drivers/Databricks/DatabricksCompositeReader.cs:
##########
@@ -108,5 +111,41 @@ private BaseDatabricksReader
DetermineReader(TFetchResultsResp initialResults)
return await
_activeReader.ReadNextRecordBatchAsync(cancellationToken);
}
+
+ public override async ValueTask<RecordBatch?>
ReadNextRecordBatchAsync(CancellationToken cancellationToken = default)
+ {
+ var result = await
ReadNextRecordBatchInternalAsync(cancellationToken);
+ // Stop the poller when we've reached the end of results
+ if (result == null)
+ {
+ StopOperationStatusPoller();
+ }
+ return result;
+ }
Review Comment:
Actually, maybe we dont stop the poller if there is an error, caller has to
call dispose() explicitly to cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
