toddmeng-db commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2241479129
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchResultFetcher.cs:
##########
@@ -247,6 +247,10 @@ private async Task FetchResultsAsync(CancellationToken
cancellationToken)
_downloadQueue.Add(EndOfResultsGuard.Instance,
cancellationToken);
_isCompleted = true;
Review Comment:
From testing:
Small nit but I think we need to avoid this here, since it's possible that
DownloadQueue is full, then exception handling would be stuck. Should I modify
the Exception handling below, or was there a reason why it it like this? (line
262) @jadewang-db
```
catch (Exception ex)
{
try
{
_downloadQueue.Add(EndOfResultsGuard.Instance,
CancellationToken.None);
}
}
```
Alternatively, we can create a new CancellationToken with Timeout for this
attempt
```
CancellationToken GetOperationStatusTimeoutToken =
ApacheUtility.GetCancellationToken(_requestTimeoutSeconds,
ApacheUtility.TimeUnit.Seconds);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
