jadewang-db commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2243607540
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -726,20 +740,15 @@ protected internal QueryResult
EnhanceGetColumnsResult(Schema originalSchema, IR
protected virtual async Task<QueryResult>
GetColumnsExtendedAsync(CancellationToken cancellationToken = default)
{
- // 1. Get all three results at once
+ // 1. Get columns result and read all data immediately
var columnsResult = await GetColumnsAsync(cancellationToken);
if (columnsResult.Stream == null)
{
// TODO: Add log or throw
return columnsResult;
}
Review Comment:
possible of avoiding this sequential change?
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchResultFetcher.cs:
##########
@@ -247,6 +247,10 @@ private async Task FetchResultsAsync(CancellationToken
cancellationToken)
_downloadQueue.Add(EndOfResultsGuard.Instance,
cancellationToken);
_isCompleted = true;
Review Comment:
thanks, a cancellation token looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
