toddmeng-db commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2248694079
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchResultFetcher.cs:
##########
@@ -257,7 +258,7 @@ private async Task FetchResultsAsync(CancellationToken
cancellationToken)
// Add the end of results guard to the queue even in case of
error
try
{
- _downloadQueue.Add(EndOfResultsGuard.Instance,
CancellationToken.None);
+ _downloadQueue.TryAdd(EndOfResultsGuard.Instance, 0);
Review Comment:
I don't want Dispose to stall, what do you think?
If caller disposes statement, and download_queue is full, we would have to
wait on however long cancellation token is configured to expire
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
