superserious-dev commented on code in PR #8073:
URL: https://github.com/apache/arrow-rs/pull/8073#discussion_r2258483206
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -39,6 +40,22 @@ macro_rules! primitive_conversion {
}};
}
+/// Convert the input array to a `VariantArray` row by row,
+/// transforming each element with `cast_fn`
+macro_rules! cast_conversion {
Review Comment:
This macro applies `cast_fn` to each element before converting it to a
Variant. Some of the remaining types will require casting before being accepted
by `Variant::from`.
We could also add the `cast_fn` argument to `primitive_conversion!` macro
and not add this macro. It would require passing something like `|v| v` (ie. a
no-op function) to the existing primitive conversions that don't require casts.
##########
parquet-variant-compute/Cargo.toml:
##########
@@ -33,6 +33,7 @@ rust-version = { workspace = true }
[dependencies]
arrow = { workspace = true }
arrow-schema = { workspace = true }
+half = { version = "2.1", default-features = false }
Review Comment:
Needed to reference `f16` in the code and in the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
