superserious-dev commented on code in PR #8073:
URL: https://github.com/apache/arrow-rs/pull/8073#discussion_r2258488318
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -92,6 +109,9 @@ pub fn cast_to_variant(input: &dyn Array) ->
Result<VariantArray, ArrowError> {
DataType::UInt64 => {
primitive_conversion!(UInt64Type, input, builder);
}
+ DataType::Float16 => {
+ cast_conversion!(Float16Type, |v: f16| -> f32 { v.into() }, input,
builder);
Review Comment:
Casted f16 to f32 so that the value can be wrapped by Variant::Float.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
