alamb commented on code in PR #8073:
URL: https://github.com/apache/arrow-rs/pull/8073#discussion_r2259872716
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -92,6 +109,9 @@ pub fn cast_to_variant(input: &dyn Array) ->
Result<VariantArray, ArrowError> {
DataType::UInt64 => {
primitive_conversion!(UInt64Type, input, builder);
}
+ DataType::Float16 => {
+ cast_conversion!(Float16Type, |v: f16| -> f32 { v.into() }, input,
builder);
Review Comment:
Makes sense to me.
In general, getting a macro that knows how to convert various Arrow types to
Variant I think is an important building block
##########
parquet-variant-compute/Cargo.toml:
##########
@@ -33,6 +33,7 @@ rust-version = { workspace = true }
[dependencies]
arrow = { workspace = true }
arrow-schema = { workspace = true }
+half = { version = "2.1", default-features = false }
Review Comment:
Yeah -- we should probably directly export he `f16` type from the arrow
crate (`pub use`) to avoid having users explicitly have to `use` half . Maybe
as a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
