jonkeane commented on code in PR #47278:
URL: https://github.com/apache/arrow/pull/47278#discussion_r2269841671
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -850,14 +850,14 @@ register_bindings_hms <- function() {
abort("All arguments must be numeric or NA_real_")
}
- total_secs <- seconds +
- Expression$create("multiply_checked", minutes, 60) +
- Expression$create("multiply_checked", hours, 3600) +
- Expression$create("multiply_checked", days, 86400)
+ total_ms <- Expression$create("multiply_checked", seconds, 1000) +
+ Expression$create("multiply_checked", minutes, 60000) +
+ Expression$create("multiply_checked", hours, 3600000) +
+ Expression$create("multiply_checked", days, 86400000)
Review Comment:
Do we need a `miliseconds` here? Or is it that someone sending subsecond
time will send it as a decimal as part of seconds, and then that gets
multiplied out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
